compiler: Enhance IR to support more advanced parlang (CUDA/HIP/SYCL) features by FabioLuporini · Pull Request #2717 · devitocodes/devito

FabioLuporini · 2025-08-14T09:13:58Z

Extended version of #2708

codecov · 2025-08-14T09:34:35Z

Codecov Report

❌ Patch coverage is 87.42138% with 20 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.08%. Comparing base (4ee88fb) to head (0917757).
⚠️ Report is 106 commits behind head on main.

Files with missing lines	Patch %	Lines
devito/passes/iet/definitions.py	72.72%	6 Missing and 3 partials ⚠️
devito/ir/cgen/printer.py	33.33%	4 Missing ⚠️
devito/passes/iet/engine.py	75.00%	4 Missing ⚠️
devito/arch/archinfo.py	0.00%	2 Missing ⚠️
devito/symbolics/extended_sympy.py	94.44%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2717      +/-   ##
==========================================
- Coverage   92.10%   92.08%   -0.03%     
==========================================
  Files         248      248              
  Lines       49654    49739      +85     
  Branches     4368     4373       +5     
==========================================
+ Hits        45734    45801      +67     
- Misses       3213     3228      +15     
- Partials      707      710       +3

Flag	Coverage Δ
pytest-gpu-aomp-amdgpuX	`71.03% <66.42%> (-0.04%)`	⬇️
pytest-gpu-nvc-nvidiaX	`72.02% <66.42%> (-0.03%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

mloubout

Minor comments but looks good

mloubout · 2025-08-14T13:30:30Z

devito/symbolics/extended_sympy.py

        return super().__mul__(other)


+class Terminal:


Is that really needed?

mloubout · 2025-08-14T13:31:12Z

devito/types/misc.py

+        self.tensor = tensor
+
+    def _hashable_content(self):
+        return super()._hashable_content() + (self.tensor,)


self.tensor._hashable_content() might be more efficient

But couldn't that potentially cause key clashes if you somehow had both a FunctionMap and its tensor in the same mapper/set? I would say the current one is safer imo

yes this is the way to go otherwise you might hash the exact same as a pure tensor

mloubout · 2025-08-14T13:31:50Z

devito/types/array.py


    is_Array = True

+    _symbol_prefix = 'a'


EdCaunt · 2025-08-14T14:34:40Z

devito/ir/support/space.py

-            self._directions = frozendict(directions)
+        directions = directions or {}
+        directions = {d: v for d, v in directions.items() if d in self.intervals}
+        directions.update({i.dim: Any for i in self.intervals


Would it be worth renaming the direction Any to avoid potential squatting on typing.Any?

we should rather ask the python developers to revisit their type hinting crazyness 😂

EdCaunt · 2025-08-14T15:20:31Z

devito/ir/support/space.py

+        self._directions = frozendict(directions)

    def __repr__(self):
        ret = ', '.join(["%s%s" % (repr(i), repr(self.directions[i.dim]))


Leftover non-fstring

EdCaunt · 2025-08-15T09:30:41Z

devito/passes/iet/definitions.py


        frees = obj._C_free

        if obj.free_symbols - {obj}:


kwargs = {'objs' if obj.free_symbols - {obj} else 'standalones': definition, efuncs': efuncs, 'frees': frees} storage.update(obj, site, **kwargs)

perhaps?

EdCaunt · 2025-08-15T11:09:01Z

devito/types/misc.py

+        self.tensor = tensor
+
+    def _hashable_content(self):
+        return super()._hashable_content() + (self.tensor,)


But couldn't that potentially cause key clashes if you somehow had both a FunctionMap and its tensor in the same mapper/set? I would say the current one is safer imo

FabioLuporini · 2025-09-30T14:21:36Z

Closing in favor to #2748 since I've just finished a massive rebase

FabioLuporini requested review from EdCaunt, georgebisbas and mloubout August 14, 2025 09:13

FabioLuporini added the compiler label Aug 14, 2025

FabioLuporini added 16 commits August 14, 2025 10:14

compiler: Add FunctionMap type

44067bf

compiler: Add ULONG to __all__

616135e

compiler: Improve lowering of LocalObjects

67a2179

compiler: Add LocalObject._mem_shared

4a903d3

compiler: Add BitwiseNot and BitwiseXor

24db970

compiler: Add LocalType._C_tag

59ff1bf

compiler: Move and enhance FunctionMap

c5891d2

arch: async-loads -> async-pipe

fec3357

compiler: Fix IREq.__repr__

e54965e

compiler: Generalize ideriv lowering

5863361

compiler: Avoid CSE across Reserved keywords

582784e

compiler: Introduce Terminal mixin for SymPy subclasses

5f680d4

compiler: Pass ctx down to _map_function_on_high_bw_mem

eab6282

compiler: Enhance _alloc_object_on_low_lat_mem

ea09060

compiler: Fix abstract_object(Array)

b877bb5

compiler: Avoid spurious items in sub_iters and dirs

f7c6f97

FabioLuporini force-pushed the tma-inception branch from 901aca9 to 7ca18ee Compare August 14, 2025 09:14

misc: Fix typo

af2339d

FabioLuporini force-pushed the tma-inception branch from 7ca18ee to af2339d Compare August 14, 2025 09:18

compiler: Pass kwargs to make_parallel

0917757

mloubout reviewed Aug 14, 2025

View reviewed changes

EdCaunt reviewed Aug 15, 2025

View reviewed changes

FabioLuporini mentioned this pull request Sep 30, 2025

compiler: Enhance IR to support more advanced parlang (CUDA/HIP/SYCL) features #2748

Closed

FabioLuporini closed this Sep 30, 2025

Conversation

FabioLuporini commented Aug 14, 2025

Uh oh!

codecov bot commented Aug 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

mloubout left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

FabioLuporini commented Sep 30, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codecov bot commented Aug 14, 2025 •

edited

Loading